[ewg] Re: [PATCH ofed-1.2]: 2 bug fixes for iSER

[Vladimir Sokolovsky]

On Tue, 2007-04-10 at 10:58 +0300, Erez Zilber wrote:
> Vlad,
> 
> Please add the following 2 fixes (already in Roland's tree) to kernel_patches/fixes.
> 
> do not assume that a task may be aborted only after the qp times out
> 
> scsi-ml may abort a command that was already sent. If the initiator is
> still trying to send the command (or data-out PDUs for that command), the
> qp may time out after scsi-ml times out. Therefore, when aborting the command,
> iSER may still have references for the command's buffers. When sending
> these PDUs will complete with an error, their resources will be released.
> 
> Signed-off-by: Erez Zilber <erezz at voltaire.com>
> ---

> -- 
> 1.4.2
> 
> do not switch context when notifying the iSCSI layer on a connection failure
> 
> When a connection is terminated asynchronously from the iSCSI
> layer's perspective, iSER needs to notify the iSCSI layer that the
> connection has failed. This is done using a workqueue (switched to
> from the iSER tasklet context). Meanwhile, the connection object (that
> holds the work struct) is released. If the workqueue function wasn't
> called yet, it will be called later with a NULL pointer that will
> crash the kernel.
> 
> The context switch (tasklet to workqueue) is not required, and
> everything can be done from the iSER tasklet. This eliminates the NULL
> work struct bug (and simplifies the code).
> 
> Signed-off-by: Erez Zilber <erezz at voltaire.com>
> ---

Added:

kernel_patches/fixes/iser_iscsi-01-ml_handle.patch
kernel_patches/fixes/iser_iscsi-02-context_switch.patch


-- 
Vladimir Sokolovsky <vlad at mellanox.co.il>
Mellanox Technologies Ltd.