[ewg] Re: [PATCH] IB/ehca: fix bugs to support rhel 4.5 in OFED 1.2.c-11

[Hoang-Nam Nguyen]

Michael,
> Can you guys fix 2.6.16 to 2.6.18 from kernel.org please?
> You can see the details in the message sent by Vlad's automated script.
I downloaded ofa_1_2_c_kernel-20070813-0520 and saw several issues:
* ehca patches for 2.6.23-rcX were incorporated, which is not acceptable
  for us to support in 1.2.c. Upstream code of ehca in kernel contains
  major changes in order to support ehca2 with new features, which is
  targeted for ofed-1.3. We have not requested to have those new
  features for ofed-1.2.1/1.2.c/1.2.5. Furthermore libehca from ofed-1.2
  does not work due to abi_version conflict.
* In kernel_addons/backport/2.6.16 (including sles10/sles10_sp1) I don't
  see the backport of kmem_cache_zalloc() as we have discussed and agreed
  on last week.
  See http://lists.openfabrics.org/pipermail/ewg/2007-August/004186.html
* Compiler error report from today's ofed_1_2_c daily build script - I
  consider 2.6.16 as an example:
----------------------------------------------------------------------------------
Build failed on powerpc with linux-2.6.16
Log:
/home/vlad/tmp/ofa_1_2_c_kernel-20070813-0200_linux-2.6.16
_powerpc_check/drivers/infiniband/hw/ehca/ehca_main.c:831: error: invalid
type argument of ->
/home/vlad/tmp/ofa_1_2_c_kernel-20070813-0200_linux-2.6.16
_powerpc_check/drivers/infiniband/hw/ehca/ehca_main.c:834: error: invalid
type argument of ->
/home/vlad/tmp/ofa_1_2_c_kernel-20070813-0200_linux-2.6.16
_powerpc_check/drivers/infiniband/hw/ehca/ehca_main.c:835: error: invalid
type argument of ->
make[4]: *** [/home/vlad/tmp/ofa_1_2_c_kernel-20070813-0200_linux-2.6.16
_powerpc_check/drivers/infiniband/hw/ehca/ehca_main.o] Error 1
make[3]: *** [/home/vlad/tmp/ofa_1_2_c_kernel-20070813-0200_linux-2.6.16
_powerpc_check/drivers/infiniband/hw/ehca] Error 2
make[2]: *** [/home/vlad/tmp/ofa_1_2_c_kernel-20070813-0200_linux-2.6.16
_powerpc_check/drivers/infiniband] Error 2
make[1]: ***
[_module_/home/vlad/tmp/ofa_1_2_c_kernel-20070813-0200_linux-2.6.16
_powerpc_check] Error 2
make[1]: Leaving directory `/home/vlad/kernel.org/powerpc/linux-2.6.16'
make: *** [kernel] Error 2
----------------------------------------------------------------------------------

  I downloaded ofa_1_2_c_kernel-20070813-0200, ran
  configure --with-core-mod --with-ehca-mod --with-ipoib-mod
--with-user_access-mod
  on our native ppc64 system and looked at ehca_main.c source code:

int __init ehca_module_init(void)
{
      ret = sysfs_create_group(&ehca_driver.driver.kobj,
&ehca_drv_attr_grp);
      if (ret) /* only complain; we can live without attributes */
#831:       ehca_gen_err("Cannot create driver attributes  ret=%d", ret);

      if (ehca_poll_all_eqs != 1) {
#834        ehca_gen_err("WARNING!!!");
            ehca_gen_err("It is possible to lose interrupts.");
      } else {
            init_timer(&poll_eqs_timer);
            poll_eqs_timer.function = ehca_poll_eqs;
            poll_eqs_timer.expires = jiffies + HZ;
            add_timer(&poll_eqs_timer);
      }

  Thus, the line number does not match as reported. It looks like we
  have some config issues on ofa build server. I'll take time tomorrow
  to look there. Please advice us how to reproduce this errors.
  Vlad, does your build script detect and report patch rejects? That
  would help to see such one error sooner.

  Needless to say I could build ofed without errors on our ppc64 systems.

Thanks
Nam