[ewg] Re: add_open_iscsi_h.patch

Michael S. Tsirkin mst at dev.mellanox.co.il
Wed Jul 25 07:12:35 PDT 2007


> Quoting Erez Zilber <erezz at voltaire.com>:
> Subject: Re: add_open_iscsi_h.patch
> 
> Michael S. Tsirkin wrote:
> 
> > > Quoting Erez Zilber <erezz at voltaire.com>:
> > > Subject: Re: add_open_iscsi_h.patch
> > >
> > > Michael S. Tsirkin wrote:
> > >
> > > > > Quoting Erez Zilber <erezz at voltaire.com>:
> > > > > Subject: Re: add_open_iscsi_h.patch
> > > > >
> > > > > Michael S. Tsirkin wrote:
> > > > >
> > > > > > Erez, add_open_iscsi_h currently does:
> > > > > >
> > > > > > -#include <scsi/iscsi_if.h>
> > > > > > +#include "iscsi_if.h"
> > > > > >
> > > > > > why is ths bit needed?
> > > > > >
> > > > >
> > > > > Strange. I remember that I couldn't build OFED 1.2 without it in the
> > > > > past. I tried to rebuild it without this now, and it compiles
> > > > > successfully, so let's remove that code.
> > > >
> > > > OK, I killed these patches completely and things still build fine.
> > > > Vlad, please pull my tree into ofed_kernel.
> > > >
> > > Yes, it also works for me. I guess that these are all leftovers.
> >
> > Deleted. Hmm. Do we want to kill them in 1.2.c too?
> >
> Yes (why not?)

Donnu. It's in bugfix-only mode after all. You decide.

-- 
MST



More information about the ewg mailing list