[ewg] Re: [ofa-general] [PATCH 1/2] IB/iser: add open-iscsi over iSER support for RHAS4 in OFED scripts

[Erez Zilber]

Vladimir Sokolovsky wrote:

>> Vlad,
>>
>> It seems that commit 553e284ffb2f380dc8d1451bfb3ad40165f04112 in
>> ofed_1_2_scripts.git is different from the patch that I submitted. For
>> example:
>>
>> My patch:
>>
>> @@ -135,7 +135,7 @@ IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES
>>  # Iser
>>  # Currently iSER is supported only on SLES10 & RHEL5
>>  case ${K_VER} in
>> -        2.6.16.*-*-*|2.6.*.el5)
>> +        2.6.16.*-*-*|2.6.*.el5|2.6.9-*.EL*)
>>          IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES} ib_iser"
>>          ;;
>>  esac
>>
>>
>> patch applied in ofed_1_2_scripts.git:
>> @@ -135,7 +135,7 @@ IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES
>>  # Iser
>>  # Currently iSER is supported only on SLES10 & RHEL5
>>  case ${K_VER} in
>> -        2.6.16.*-*-*|2.6.*.el5)
>> +        2.6.16.*-*-*|2.6.*.el5|2.6.9-[3-5]*.EL*) <-- this line is
>> different
>>          IB_KERNEL_PACKAGES="${IB_KERNEL_PACKAGES} ib_iser"
>>          ;;
>>  esac
>>
>> Why is that?
>>
>> Erez
>
> You have added backport patches for RHEL4.0 U3, U4, U5.
> 2.6.9-*.EL* matches also U2. So, installation fails on RHEL 4.0 U2
> with your patch.
>
> Vladimir

You are right and I agree with your fix. Next time, just let me know if
you don't apply a patch as is.

Thanks,
Erez