[ewg] Re: [PATCH ofed-1.4] NFSRDMA: makefile fixes

Jeff Becker Jeffrey.C.Becker at nasa.gov
Wed Aug 6 15:13:49 PDT 2008


Thanks Steve!

-jeff

Steve Wise wrote:
> From: Steve Wise <swise at opengridcomputing.com>
>
> - install rule was misnamed
> - an innocent comment line caused the install rule to not create
> the target directories causing all the module mv commands to fail.
>
> Signed-off-by: Steve Wise <swise at opengridcomputing.com>
> ---
>
>  ofed_scripts/makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ofed_scripts/makefile b/ofed_scripts/makefile
> index 6a8de5d..fb460e5 100644
> --- a/ofed_scripts/makefile
> +++ b/ofed_scripts/makefile
> @@ -5,7 +5,7 @@ all:
>  .PHONY: install_kernel_iscsi
>  .PHONY: install_kernel_cxgb3
>  .PHONY: install_kernel_rds
> -.PHONY: install_kernel_xprtrdma
> +.PHONY: install_kernel_nfsrdma
>  .PHONY: install_kernel_mlx4
>  	
>  .DELETE_ON_ERROR:
> @@ -41,7 +41,7 @@ install_kernel: install_kernel_cxgb3
>  endif
>  
>  ifeq ($(CONFIG_SUNRPC_XPRT_RDMA),m)
> -install_kernel: install_kernel_xprtrdma
> +install_kernel: install_kernel_nfsrdma
>  endif
>  
>  ifeq ($(CONFIG_RDS),m)
> @@ -217,8 +217,8 @@ install_kernel_iscsi: install_modules
>  
>  install_kernel_nfsrdma: install_modules
>  	# backup all the modules
> -	NFSRDMA_PATHS="fs/nfs fs/nfsd fs/lockd fs/nfs_common net/sunrpc net/sunrpc/xprtrdma net/sunrpc/auth_gss"; \
>  	# Copy new nfs rdma kernel modules to $(DESTDIR)/$(MODULES_DIR)/kernel
> +	NFSRDMA_PATHS="fs/nfs fs/nfsd fs/lockd fs/nfs_common net/sunrpc net/sunrpc/xprtrdma net/sunrpc/auth_gss"; \
>  	NFSRDMA_MODS="net/sunrpc/auth_gss/auth_rpcgss.ko net/sunrpc/auth_gss/rpcsec_gss_krb5.ko net/sunrpc/auth_gss/rpcsec_gss_spkm3.ko fs/lockd/lockd.ko fs/nfs_common/nfs_acl.ko fs/nfsd/nfsd.ko fs/nfs/nfs.ko net/sunrpc/sunrpc.ko net/sunrpc/xprtrdma/svcrdma.ko net/sunrpc/xprtrdma/xprtrdma.ko"; \
>  	if [ -d $(CWD)/lib/modules/$(KVERSION)/net/sunrpc/xprtrdma ]; then \
>  		for each_path in $$NFSRDMA_PATHS; do \
>   




More information about the ewg mailing list