[ewg] Re: [PATCH RFCv2] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

[Steve Wise]

Or Gerlitz wrote:
> Steve Wise wrote:
>> From: Steve Wise <swise at opengridcomputing.com>
>>
>> This is needed for iwarp providers that support native and rdma
>> connections over the same interface.
>>
>> Optionally turned on by the new rdma_cm unify_tcp_port_space module 
>> option.
> OK, I guess this can get it, as least from my side, thanks for fixing it.
>>
>> --- a/drivers/infiniband/core/cma.c
>> +++ b/drivers/infiniband/core/cma.c
>> @@ -809,6 +815,8 @@ static void cma_release_port(struct 
>> rdma_id_private *id_priv)
>>          kfree(bind_list);
>>      }
>>      mutex_unlock(&lock);
>> +    if (id_priv->sock)
>> +        sock_release(id_priv->sock);
>>  }
>
> any specific reason to put this here and not in rdma_destroy_id?
>
> Or.

Seemed like cma_release_port() is where I should release the port.  And 
for sockets, the only way to release the port is to release the socket.


Steve.