[ewg] Re: [PATCH] IB/core - ib_wr_opcode change to add IB_WR_LSO breaks ib_ipath

Vladimir Sokolovsky vlad at dev.mellanox.co.il
Sun Jan 6 01:41:31 PST 2008


Ralph Campbell wrote:
>
> Vlad, please pull from git.openfabrics.org/~ralphc/linux-2.6.git in
> the ofed_kernel_2_6_24_rc1 branch. This is an up-to-date clone
> of git://git.openfabrics.org/ofed_1_3/linux-2.6.git with the
> following change:
>
>
> The ib_ipath driver depends on /usr/include/infiniband/verbs.h
> enum ibv_wr_opcode matching the kernel's ib_verbs.h
> enum ib_wr_opcode. The recent change to add IB_WR_LSO breaks this.
>
> Now, you may argue that the kernel should not depend on this equivalence
> but you would then need to define IBV_WR_RDMA_WRITE, etc. in some
> kernel header file and do a table look up to map from user to
> kernel opcode values. Since I don't see any other code which depends
> on the value of IB_WR_LSO, I think the following patch is the right
> fix.
>
> Signed-off-by: Ralph Campbell <ralph.campbell at qlogic.com>
>
Done,

Regards,
Vladimir



More information about the ewg mailing list