[ewg] Re: [ofa-general] [PATCH v2] IB/ipoib: copy small SKBs in CM mode

Eli Cohen eli at dev.mellanox.co.il
Wed May 28 04:13:45 PDT 2008


On Tue, 2008-05-27 at 13:00 -0700, Roland Dreier wrote:
> I changed this to a build bug, to avoid waiting until runtime to notice
> this problem:
> 
> +       /*
> +        * When copying small received packets, we only copy from the
> +        * linear data part of the SKB, so we rely on this condition.
> +        */
> +       BUILD_BUG_ON(IPOIB_CM_COPYBREAK > IPOIB_CM_HEAD_SIZE);

I was looking for this one thing to make this check at compile time...
thanks for letting us know.




More information about the ewg mailing list