[ewg] Re: [PATCH] IB/ipoib: set neigh->dgid upon ipoib_neigh creation

Yossi Etigin yosefe at Voltaire.COM
Thu Mar 26 10:05:56 PDT 2009


Eli Cohen wrote:
> @@ -481,7 +479,9 @@ static void path_rec_completion(int status,
>  				__skb_queue_tail(&skqueue, skb);
>  		}
>  		path->valid = 1;
> -	}
> +	} else
> +		list_for_each_entry_safe(neigh, tn, &path->neigh_list, list)
> +			memset(&neigh->dgid, 0, sizeof neigh->dgid);
>  
>  	path->query = NULL;
>  	complete(&path->done);

In case of SM failover, there is a period of time where there is no sm_ah in sa,
so ib_sa_path_rec_get() returns -EAGAIN and path_rec_start() fails. This means the
code above will not be called, and again - no path until next arp refresh.

--Yossi



More information about the ewg mailing list