[ewg] [PATCHv8 06/11] ipoib: avoid ipoib over IBoE

Eli Cohen eli at dev.mellanox.co.il
Thu May 6 04:02:33 PDT 2010


On Wed, May 05, 2010 at 03:27:51PM -0700, Roland Dreier wrote:
>  > @@ -1383,6 +1385,9 @@ static void ipoib_remove_one(struct ib_device *device)
>  >  	dev_list = ib_get_client_data(device, &ipoib_client);
>  >  
>  >  	list_for_each_entry_safe(priv, tmp, dev_list, list) {
>  > +		if (rdma_port_link_layer(device, priv->port) != IB_LINK_LAYER_INFINIBAND)
>  > +			continue;
> 
> Why do we need this chunk here?  How could a netdev get on our list if
> we never create IPoIB interfaces for IBoE ports?
> 

Right, this is not necessary and can be removed.



More information about the ewg mailing list