[ewg] [PATCHv8 04/11] ib_core: IBoE CMA device binding

Roland Dreier rdreier at cisco.com
Fri May 14 15:08:14 PDT 2010


 > > I'm having a hard time working out why the iboe case needs to schedule
 > > to a work queue here since its already in process context, right?  It
 > > seems it would be really preferable to avoid all the extra pointer
 > > munging and reference counting, and just call things directly.

 > I assume that the caller might attempt to acquire the same lock when
 > calling join and in the callback. Specifically, ucma_join_multicast()
 > calls rdma_join_multicast() with file->mut acquired and
 > ucma_event_handler() does the same.

I see... we can't call the consumer's callback directly since it might
have locking assumptions.

It would be nice if we didn't have this reference counting sometimes
used and sometimes not used.  I'll have to think about whether this can
be made cleaner.

 - R.
-- 
Roland Dreier <rolandd at cisco.com> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html



More information about the ewg mailing list