[ewg] Patch breaks OFED 1.5.3: [PATCH] ibdiagpath: Properly index VlArbTable during QoS test

[Mike Heinz]

The version of  ibdiagpath included with OFED 1.5.3-rc3 contains syntax errors which prevent it from executing on the systems I've tested (using TCL 8.4).  Attempts to use ibdiagpath fail with an error message:

> -I---------------------------------------------------
> -I- QoS on Path Check
> -I---------------------------------------------------
> bad index "0+1": must be integer or end?-integer?

After doing some research and debugging, I traced the problem to a patch applied back in October:

commit f3cf1f7c15ca24598fdf68b9ba71788b386b2f14
Author: John Jolly <jjolly at novell.com>
Date:   Wed Oct 6 17:29:48 2010 +0200

    ibdiagpath: Properly index VlArbTable during QoS test

    Description: ibdiagpath: Properly index VlArbTable during QoS test
    Symptom:     Error 'invalid bareword "vl_entry"' during "QoS on
                 Path Check"
    Problem:     The 'dump' command within the smVlArbTableMad command
                 appends '-vl_entry' to the beginning of the array.
                 The ibdebug.tcl script does not properly handle this
                 extra element at the beginning of the array.
    Solution:    Offset the index value by one when referencing the
                 array.

    Signed-off-by: John Jolly <jjolly at novell.com>
    Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>

Unfortunately, this patch isn't valid TCL code (at least not in TCL 8.4) and does not appear to be needed at all.

For example:

> set entry [lindex $values $i+1]

Is not syntactically correct TCL.  In order for it to be correct it would have to be

> set entry [lindex $values [expr $i+1]]

However, the patch does not appear to be needed at all. Reverting the patch, allows ibdiagpath to complete successfully:

> -I---------------------------------------------------
> -I- QoS on Path Check
> -I---------------------------------------------------
> -W- Blocked VLs:3 4 5 at node:homer lid=0x0002 guid=0x00066a00a000707f dev=25208    > port:1
> -W- SLs:3 4 5 6 7 8 9 10 11 12 13 14 15 are blocked due to VLArb node:homer
>     lid=0x0002 guid=0x00066a00a000707f dev=25208 in-port:0 out-port:1
> -W- Blocked VLs:3 4 5 at node: lid=0x0001 guid=0x00066a00d9000275 dev=47396
>     port:21
> -W- SLs:3 4 5 6 7 8 9 10 11 12 13 14 15 mapped to VL > 5 at node: lid=0x0001
>     guid=0x00066a00d9000275 dev=47396 in-port:14 out-port:21
> -I- The following SLs can be used:0 1 2

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.