<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.2900.2873" name=GENERATOR></HEAD>
<BODY>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006>Hi,</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>After implementing
and submitting the ibsrpdm patches I got the following important
remarks:</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006></SPAN></FONT><FONT
face=Arial size=2><SPAN class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>1) Sometimes there
is a need to add a target twice.</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>2) It it unnecessary
complication to the kernel to look for a target in the targets list in
order to remove it.</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>3) There is a
conceptual problem in the list_target query - In sysfs each file should report
only one value.</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>Before implementing
the fixes according to this remarks, I want to see if there are any comments to
the changes I'm going to do.</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006></SPAN></FONT><FONT
face=Arial size=2><SPAN class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>I'm going to change
ibsrpdm and SRP driver code in the following manner:</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>1) There is going to
be an attribute for a target indicating if it was added by the daemon (Named
daemons).</SPAN></FONT><FONT face=Arial size=2><SPAN class=027421013-04052006>
Only the daemon should add targets with this attribute set.</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>2) The kernel will
not allow the daemon to add the same target twice. Regular activation of
add_target can add multiple instances of the same target.</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>3) list_target query
will be removed. The information will be in several directories in sysfs (One
for each target) - Roland, vu, can you send me a pointer that
explains which target information can be found in the sysfs
today?</SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN
class=027421013-04052006></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006>4) I'll c<FONT
face=Arial size=2><SPAN class=560225608-04052006>hange the way I've implemented
the activation of remove target. There will be a remove target file for
each existing target directory in sysfs, echo 1 to this file will remove the
corresponding target.</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006></SPAN></FONT></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006>5) The daemon will remove only targets
that it added. (Has the daemons attribute
set).</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006></SPAN></FONT></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006>6) Adding execution modes to
ibsrpdm:</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006> a) When activated
without flags or with -c flag, ibsrpdm will executes once (has before)
and display the targets in the network.</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006> b) When activated with
-l flag, ibsrpdm will be activated in a loop and display at each
cycle the targets that join the network and the targets the leaves the
network.</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006> c) When activated
with -l and -a flags, ibsrpdm will be activated as a daemon
that adds targets that join the
network.</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006> d) When activated
with -l and -r flags, ibsrpdm will be activated as a daemon that removes
targets that leave the network.</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006> e) When activated
with -l, -a and -r flags, ibsrpdm will be activated as a daemon
that adds targets that join the network, and removes targets that
leave the network.</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006></SPAN></FONT></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006>The reason we need option b, is because
costumers may want to add the targets in a certain order (for binding
purposes).</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006></SPAN></FONT></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006>Any
comments?</SPAN></FONT></SPAN></FONT></DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006></SPAN></FONT></SPAN></FONT> </DIV>
<DIV><FONT face=Arial size=2><SPAN class=027421013-04052006><FONT face=Arial
size=2><SPAN class=560225608-04052006>Ishai
Rabinovitz</SPAN></FONT></SPAN></FONT></DIV></SPAN></FONT></SPAN></FONT></DIV></SPAN></FONT></SPAN></FONT></DIV></BODY></HTML>