[openib-general] GSI compromise

Roland Dreier roland at topspin.com
Tue Aug 3 21:19:39 PDT 2004


This looks pretty sane to me -- I really like the proposed way of
handling redirection.

...just a few questions/comments/nitpicks:

 - what callback will a consumer receive if no response is received
   before a send timeout?
 - where does transaction ID allocation happen?
 - how does the MAD layer know how many elements are in the
   method_array parameter of ib_mad_reg_class()?
 - where is the GRH info stored if ib_mad_msg.global_route is set?
 - should we use a "struct list_head" instead of our own type for
   ib_mad_msg.next?
 - I assume we'll have helpers for parsing ClassPortInfo redirection
   responses and updating a message.
 - are any values other than IB_QPT_SMI and IB_QPT_GSI valid for the
   qp_type parameter of ib_mad_reg_class()?
 - should ib_qp_redir()/ib_process_wc() have "_mad_" in their name to
   give more of a clue as to what they do?
 - are you thinking that a single "support RMPP" flag would be passed
   into ib_mad_reg_class() and ib_qp_redir()?

Thanks,
  Roland



More information about the general mailing list