[openib-general] Re: [openib-commits] r607 - in gen2/branches/roland-merge/src/linux-kernel/infiniband: core hw/mthca include ulp/ipoib

[Tom Duffy]

On Mon, 2004-08-09 at 10:43 -0700, wrote:
>    gen2/branches/roland-merge/src/linux-kernel/infiniband/hw/mthca/mthca_provider.c

> Modified: gen2/branches/roland-merge/src/linux-kernel/infiniband/hw/mthca/mthca_provider.c
> ===================================================================
> --- gen2/branches/roland-merge/src/linux-kernel/infiniband/hw/mthca/mthca_provider.c	2004-08-09 17:26:34 UTC (rev 606)
> +++ gen2/branches/roland-merge/src/linux-kernel/infiniband/hw/mthca/mthca_provider.c	2004-08-09 17:43:29 UTC (rev 607)
>  
> -static int mthca_address_destroy(struct ib_address *address)
> +static int mthca_ah_destroy(struct ib_ah *ah)
>  {
> -	mthca_destroy_ah(to_mdev(address->device), address->private);
> -	kfree(address->private);
> +	mthca_destroy_ah(to_mdev(ah->device), ah);
> +	kfree(ah);
>  
>  	return 0;
>  }

This is causing a build warning:

  CC [M]  drivers/infiniband/hw/mthca/mthca_provider.o
/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/drivers/infiniband/hw/mthca/mthca_provider.c: In function `mthca_ah_destroy':
/build1/tduffy/openib-work/linux-2.6.8-rc3-openib/drivers/infiniband/hw/mthca/mthca_provider.c:292: warning: passing arg 2 of `mthca_destroy_ah' from incompatible pointer type

This fixes it...

Index: drivers/infiniband/hw/mthca/mthca_provider.c
===================================================================
--- drivers/infiniband/hw/mthca/mthca_provider.c	(revision 610)
+++ drivers/infiniband/hw/mthca/mthca_provider.c	(working copy)
@@ -289,7 +289,7 @@
 
 static int mthca_ah_destroy(struct ib_ah *ah)
 {
-	mthca_destroy_ah(to_mdev(ah->device), ah);
+	mthca_destroy_ah(to_mdev(ah->device), (struct mthca_ah *)ah);
 	kfree(ah);
 
 	return 0;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20040809/5c9bfd66/attachment.sig>