Looks reasonable -- kernel-doc-nano-HOWTO.txt says that constants should be marked with '%' instead of '@' though. However I'm not sure how kernel-doc handles enum declarations (since it mostly seems to be for documenting functions). - Roland