[openib-general] more ib_verbs.h nits

Sean Hefty mshefty at ichips.intel.com
Fri Jul 30 10:57:59 PDT 2004


On Fri, 30 Jul 2004 14:53:06 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> enum ib_qp_attr_mask {
>  IB_QP_STATE   = 1,
>  IB_QP_EN_SQD_ASYNC_NOTIFY = (1<<1),
>  IB_QP_REMOTE_ATOMIC_FLAGS = (1<<3),
> 
> Should IB_QP_REMOTE_ATOMIC_FLAGS be 1<<2 and so on for the bits after that
> one ?

I had removed the mask that was (1<<2) and didn't updates the other values.  I was just going to insert a new entry at that location.  (E.g. I need to add support to resize the QP.)

 
> Also, should ib_get_special_qp be called ib_create_special_qp ?

I used "get" to better match the terminology given in the spec.  (It's probably what VAPI used as well.)

Btw, please continue to send nits like these.



More information about the general mailing list