[openib-general] [PATCH] fix memory leak in ib_mad_recv_done_handler

Hal Rosenstock halr at voltaire.com
Thu Nov 4 14:17:32 PST 2004


On Thu, 2004-11-04 at 16:31, Krishna Kumar wrote: 
> Also, updated a comment so that it is known that the recv_handler
> (when it is implemented) is in charge of freeing up recv during it's
> processing. Applies to gen2/trunk.

Thanks. Applied the commentary part of the change.

The memory leak "fix" needs some work as the MAD layer now oops on a
NULL pointer dereference at virtual address 0.

I omitted this one line change (for now):

-               kmem_cache_free(ib_mad_cache, recv);
+               ib_free_recv_mad(&recv->header.recv_wc);

-- Hal




More information about the general mailing list