[openib-general] [PATCH] agent: Fix agent_mad_send PCI mapping and gather address and length

Roland Dreier roland at topspin.com
Wed Nov 10 10:02:04 PST 2004


    Roland> I think keeping the MAD code simpler is probably best right now.

    Hal> Hope that is for technical reasons and not for the recent missteps.

Yes, it's just that the MAD code is quite complicated already with
multiple tests for DR SMPs etc; mad.c alone is over 2000 lines now.  I
don't think you could even find a microbenchmark that could measure
the improvement in testing the response bit in the MAD code rather
than calling into process_mad for every packet, so I don't think we
need to add more code to the MAD layer to do it.

 - R.




More information about the general mailing list