[openib-general] Re: [PATCH] handle QP0/1 send queue overrun

Hal Rosenstock halr at voltaire.com
Wed Nov 10 12:43:03 PST 2004


On Wed, 2004-11-10 at 12:36, Hal Rosenstock wrote:
> I will break this up into two chunks: 
> 2. the rest (mad changes) excluding the already applied patch (to bring
> the ports up to ACTIVE) which I believe is temporary.

A few minor questions (before applying this):

1. Why was BUG_ON removed from dequeue_mad ?

2. A couple of questions related to send_wr->num_sge checking.
a. Should this be pushed down to mthca and detected there rather than at
the MAD layer ?
b. If it is to stay at the MAD layer, shouldn't there be a check inside
the while (send_wr) loop rather than above it ?

-- Hal




More information about the general mailing list