[openib-general] [PATCH] ipoib: Free AHs

[Hal Rosenstock]

On Thu, 2004-11-11 at 11:31, Roland Dreier wrote:
> This patch corrects the fact that IPoIB leaks all of its address
> handles by creating a list of dead AHs and freeing an AH once all the
> sends using it complete.

A couple of compile warnings:
drivers/infiniband/ulp/ipoib/ipoib_main.c: In function
`ipoib_neigh_destructor':
drivers/infiniband/ulp/ipoib/ipoib_main.c:536: warning: unused variable
`priv'

and

drivers/infiniband/ulp/ipoib/ipoib_multicast.c: In function
`ipoib_mcast_free':
drivers/infiniband/ulp/ipoib/ipoib_multicast.c:67: warning: unused
variable `priv'

Here's a trivial patch for these.

-- Hal

Index: ipoib_main.c
===================================================================
--- ipoib_main.c	(revision 1205)
+++ ipoib_main.c	(working copy)
@@ -533,10 +533,10 @@
 
 static void ipoib_neigh_destructor(struct neighbour *neigh)
 {
-	struct ipoib_dev_priv *priv = netdev_priv(neigh->dev);
 	struct ipoib_path     *path = IPOIB_PATH(neigh);
 
-	ipoib_dbg(priv, "neigh_destructor for %06x " IPOIB_GID_FMT "\n",
+	ipoib_dbg(netdev_priv(neigh->dev),
+		  "neigh_destructor for %06x " IPOIB_GID_FMT "\n",
 		  be32_to_cpup((__be32 *) neigh->ha),
 		  IPOIB_GID_ARG(*((union ib_gid *) (neigh->ha + 4))));
 
Index: ipoib_multicast.c
===================================================================
--- ipoib_multicast.c	(revision 1205)
+++ ipoib_multicast.c	(working copy)
@@ -64,9 +64,9 @@
 static void ipoib_mcast_free(struct ipoib_mcast *mcast)
 {
 	struct net_device *dev = mcast->dev;
-	struct ipoib_dev_priv *priv = netdev_priv(dev);
 
-	ipoib_dbg_mcast(priv, "deleting multicast group " IPOIB_GID_FMT "\n",
+	ipoib_dbg_mcast(netdev_priv(dev),
+			"deleting multicast group " IPOIB_GID_FMT "\n",
 			IPOIB_GID_ARG(mcast->mcmember.mgid));
 
 	if (mcast->ah)