[openib-general] [PATCH] fix sparse warnings in mthca

Tom Duffy Tom.Duffy at Sun.COM
Mon Nov 15 13:31:37 PST 2004


Was getting warnings like: "warning: Using plain integer as NULL
pointer" when sparse checking on x86_64.

Signed-off-by: Tom Duffy <tduffy at sun.com>

Index: drivers/infiniband/hw/mthca/mthca_doorbell.h
===================================================================
--- drivers/infiniband/hw/mthca/mthca_doorbell.h	(revision 1234)
+++ drivers/infiniband/hw/mthca/mthca_doorbell.h	(working copy)
@@ -40,7 +40,7 @@
 
 #define MTHCA_DECLARE_DOORBELL_LOCK(name)
 #define MTHCA_INIT_DOORBELL_LOCK(ptr)    do { } while (0)
-#define MTHCA_GET_DOORBELL_LOCK(ptr)      (0)
+#define MTHCA_GET_DOORBELL_LOCK(ptr)      (NULL)
 
 static inline void mthca_write64(u32 val[2], void __iomem *dest,
 				 spinlock_t *doorbell_lock)
@@ -53,7 +53,7 @@
 
 #define MTHCA_DECLARE_DOORBELL_LOCK(name)
 #define MTHCA_INIT_DOORBELL_LOCK(ptr)    do { } while (0)
-#define MTHCA_GET_DOORBELL_LOCK(ptr)      (0)
+#define MTHCA_GET_DOORBELL_LOCK(ptr)      (NULL)
 
 static inline unsigned long mthca_get_fpu(void)
 {

-- 
Tom Duffy <tom.duffy at sun.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20041115/a3f13d38/attachment.sig>


More information about the general mailing list