[openib-general] Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA(Subnet Administration) query support

[Fab Tillier]

> From: Greg KH [mailto:greg at kroah.com]
> Sent: Monday, November 22, 2004 2:25 PM
> 
> > +struct ib_sa_hdr {
> > +	u64			sm_key;
> > +	u16			attr_offset;
> > +	u16			reserved;
> > +	ib_sa_comp_mask		comp_mask;
> > +} __attribute__ ((packed));
> 
> Why is this packed?
> 
> > +struct ib_sa_mad {
> > +	struct ib_mad_hdr	mad_hdr;
> > +	struct ib_rmpp_hdr	rmpp_hdr;
> > +	struct ib_sa_hdr	sa_hdr;
> > +	u8			data[200];
> > +} __attribute__ ((packed));
> 
> Same here?

These describe on-the-wire IB structures, and their definition matches the
IB spec (Version 1.1, Volume 1)

struct ib_mad_hdr matches "Standard MAD Header", Figure 144
struct ib_rmpp_hdr matches "RMPP MAD Header", Figure 168
struct ib_sa_hdr and struct ib_sa_mad match "SA Header", Figure 193

Hope that answers your question - let us know if it doesn't.

Cheers,

- Fab