[openib-general] Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support

[Greg KH]

On Mon, Nov 22, 2004 at 10:47:29PM -0800, Roland Dreier wrote:
>     Greg> Yeah, but a name in each file is much nicer.
> 
> Very little of the kernel seems to follow this rule right now.

I agree, but it's good to add this for new files.

>     Greg> One comment, the file drivers/infiniband/core/cache.c has a
>     Greg> license that is illegal due to the contents of the file.
>     Greg> Please change the license of the file to GPL only.
> 
> ?? Can you explain this?  What makes that file special?

You are using a specific data structure that is only licensed to be used
in GPL code.  By using it in code that has a non-GPL license (like the
dual license you have) you are violating the license of that code, and
open yourself up to lawsuits by the holder of that code.

There, can I be vague enough?  :)

To be straightforward, either drop the RCU code completely, or change
the license of your code.  

Hm, because of the fact that you are linking in GPL only code into this
code (because of the .h files you are using) how could you ever expect
to use a BSD-like license for this collected work?

Aren't licenses fun...

thanks,

greg k-h