[openib-general] Re: [PATCH] [re-send] cleanup/fixes for handle_outgoing_smp

[Sean Hefty]

Hal Rosenstock wrote:

> On Mon, 2004-11-29 at 14:40, Sean Hefty wrote:
> 
> 
>>-		if (mad_agent_priv->agent.send_handler) {
>>-			/* Now, complete send */
>>-			mad_send_wc.status = IB_WC_SUCCESS;
>>-			mad_send_wc.vendor_err = 0;
>>-			mad_send_wc.wr_id = send_wr->wr_id;
>>-			mad_agent_priv->agent.send_handler(
>>-						mad_agent,
>>-						&mad_send_wc);
> 
> 
>>+	/* Complete send */
>>+	mad_send_wc.status = IB_WC_SUCCESS;
>>+	mad_send_wc.vendor_err = 0;
>>+	mad_send_wc.wr_id = send_wr->wr_id;
>>+	mad_agent->send_handler(mad_agent, &mad_send_wc);
>>+	ret = 1;
> 
> 
> Currently, it isn't safe to eliminate the check for the send_handler.
> (The registration code does not guarantee that a send_handler was
> supplied; it only does in the case where no registration request is
> supplied with the registration). 
> 
> Should a send handler always be required or should this check be added
> back in ?

The send_handler is checked in ib_post_send_mad.