[openib-general] [PATCH] reformat code to within 80 columns

Sean Hefty mshefty at ichips.intel.com
Thu Oct 7 11:55:22 PDT 2004


On Thu, 7 Oct 2004 11:49:43 -0700
Sean Hefty <mshefty at ichips.intel.com> wrote:

> Only purpose of patch is to reformat code to keep it within 80 columns.  The resulting code highlights some areas where we may want to look at restructing it.
> 
> - Sean

Same purpose - different file... SMI code, which was not in last patch.

Index: access/ib_smi.c
===================================================================
--- access/ib_smi.c	(revision 953)
+++ access/ib_smi.c	(working copy)
@@ -319,7 +319,8 @@
 	}
 	spin_unlock_irqrestore(&ib_smi_port_list_lock, flags);
 	if (!port_priv) {
-		printk(KERN_ERR "smp_send: no matching MAD agent 0x%x\n", (unsigned int)mad_agent);
+		printk(KERN_ERR "smp_send: no matching MAD agent 0x%x\n",
+		       (unsigned int)mad_agent);
 		return;
 	}
 
@@ -424,7 +425,8 @@
 	}
 
 	if (smi_check_forward_smp(mad_agent, smp)) {
-		smi_send_smp(mad_agent, smp, mad_recv_wc, mad_recv_wc->wc->slid);
+		smi_send_smp(mad_agent, smp, mad_recv_wc,
+			     mad_recv_wc->wc->slid);
 		return 0;
 	}
 	
@@ -451,7 +453,8 @@
 	/* Hold lock longer !!! */
 	spin_unlock_irqrestore(&ib_smi_port_list_lock, flags);
 	if (!port_priv) {
-		printk(KERN_ERR "smi_send_handler: no matching MAD agent 0x%x\n", (unsigned int)mad_agent);
+		printk(KERN_ERR "smi_send_handler: no matching MAD agent "
+		       "0x%x\n", (unsigned int)mad_agent);
 		return;
 	}
 
@@ -510,7 +513,8 @@
 	/* First, check if port already open for SMI */
 	spin_lock_irqsave(&ib_smi_port_list_lock, flags);
 	list_for_each_entry(entry, &ib_smi_port_list, port_list) {
-		if (entry->mad_agent->device == device && entry->port_num == port_num) {
+		if (entry->mad_agent->device == device && 
+		    entry->port_num == port_num) {
 			port_priv = entry;
 			break;
 		}
@@ -542,7 +546,8 @@
 	bitmap_zero((unsigned long *)&reg_req.method_mask, IB_MGMT_MAX_METHODS);
 	set_bit(IB_MGMT_METHOD_GET, (unsigned long *)&reg_req.method_mask);
 	set_bit(IB_MGMT_METHOD_SET, (unsigned long *)&reg_req.method_mask);
-	set_bit(IB_MGMT_METHOD_TRAP_REPRESS, (unsigned long *)&reg_req.method_mask);
+	set_bit(IB_MGMT_METHOD_TRAP_REPRESS, 
+		(unsigned long *)&reg_req.method_mask);
 
 	port_priv->mad_agent = ib_register_mad_agent(device, port_num,
 						     IB_QPT_SMI,
@@ -582,7 +587,8 @@
 
 	spin_lock_irqsave(&ib_smi_port_list_lock, flags);
 	list_for_each_entry(entry, &ib_smi_port_list, port_list) {
-		if (entry->mad_agent->device == device && entry->port_num == port_num) {
+		if (entry->mad_agent->device == device && 
+		    entry->port_num == port_num) {
 			port_priv = entry;
 			break;
 		}



More information about the general mailing list