[openib-general] [PATCH] ib_mad.c: Fix bug in completion handler when status != success

Roland Dreier roland at topspin.com
Mon Oct 25 19:12:30 PDT 2004


This is no good:

+		if (wc.status != IB_WC_SUCCESS) {
+			printk(KERN_ERR PFX "Completion error %d WRID 0x%Lx\n",
+                                       wc.status, (unsigned long long)
wc.wr_id);
+		} else 

if a request fails we'll never complete it.  eg if a consumer uses a
bad L_Key for a send request, the send will never complete (and if the
consumer ever does ib_unregister_mad_agent it will hang waiting for
the send to finish).

 - R.



More information about the general mailing list