[openib-general] [PATCH] sa_query: Remove debug print statement

Roland Dreier roland at topspin.com
Fri Oct 29 09:21:31 PDT 2004


Actually how about this:

Index: infiniband/core/mad.c
===================================================================
--- infiniband/core/mad.c	(revision 1098)
+++ infiniband/core/mad.c	(working copy)
@@ -1172,9 +1172,6 @@
                                        wc.status, (unsigned long long) wc.wr_id);
 			ib_mad_send_done_handler(port_priv, &wc);
 		} else {
-			printk(KERN_DEBUG PFX "Completion opcode 0x%x WRID 0x%Lx\n",
-			       wc.opcode, (unsigned long long) wc.wr_id);
-
 			switch (wc.opcode) {
 			case IB_WC_SEND:
 				ib_mad_send_done_handler(port_priv, &wc);
@@ -1536,7 +1533,8 @@
 	ret = ib_modify_qp(qp, attr, attr_mask, &qp_cap);
 	kfree(attr);
 
-	printk(KERN_DEBUG PFX "ib_mad_change_qp_state_to_init ret = %d\n", ret);
+	if (ret)
+		printk(KERN_WARNING PFX "ib_mad_change_qp_state_to_init ret = %d\n", ret);
 	return ret;
 }
 
@@ -1562,7 +1560,8 @@
 	ret = ib_modify_qp(qp, attr, attr_mask, &qp_cap);
 	kfree(attr);
 
-	printk(KERN_DEBUG PFX "ib_mad_change_qp_state_to_rtr ret = %d\n", ret);
+	if (ret)
+		printk(KERN_WARNING PFX "ib_mad_change_qp_state_to_rtr ret = %d\n", ret);
 	return ret;
 }
 
@@ -1589,7 +1588,8 @@
 	ret = ib_modify_qp(qp, attr, attr_mask, &qp_cap);
 	kfree(attr);
 
-	printk(KERN_DEBUG PFX "ib_mad_change_qp_state_to_rts ret = %d\n", ret);
+	if (ret)
+		printk(KERN_WARNING PFX "ib_mad_change_qp_state_to_rts ret = %d\n", ret);
 	return ret;
 }
 
@@ -1615,7 +1615,8 @@
 	ret = ib_modify_qp(qp, attr, attr_mask, &qp_cap);
 	kfree(attr);
 
-	printk(KERN_DEBUG PFX "ib_mad_change_qp_state_to_reset ret = %d\n", ret);
+	if (ret)
+		printk(KERN_WARNING PFX "ib_mad_change_qp_state_to_reset ret = %d\n", ret);
 	return ret;
 }
 
@@ -1783,8 +1784,6 @@
 			else
 				goto error7;
 		}
-		printk(KERN_DEBUG PFX "Created ib_mad QP %d\n",
-		       port_priv->qp[i]->qp_num);
 	}
 
 	spin_lock_init(&port_priv->reg_lock);



More information about the general mailing list