[openib-general] [PATCH] ib_mad.c: Filter SMI and GSI packets if received on wrong QPN

[Hal Rosenstock]

On Tue, 2004-09-14 at 11:52, Sean Hefty wrote:
> By the way, looking at the various SMI implementations available, 
> I think that it makes sense to just merge that code into ib_mad.c. 
> A good portion of the SMI validates the MAD and determines if the 
> MAD should be routed to the local device via the process_mad 
> routine.  Thoughts?  

Here's my $0.02 worth...
I would prefer to keep this in at least a separate file (something like
ib_smi.c) if possible. Right now, there is a validate_mad routine in the
MAD receive path. That routine could call validate_smi which could
perform the validation based on whether it is an incoming LR or DR
packet. I see no reason for the SMI and MAD layer to be in separate
modules.

-- Hal