[openib-general] [PATCH] beginnings of SMI

[Hal Rosenstock]

On Wed, 2004-09-15 at 13:02, Hal Rosenstock wrote:
> On Wed, 2004-09-15 at 12:45, Sean Hefty wrote:
> > On Tue, 14 Sep 2004 15:18:39 -0700
> > Sean Hefty <mshefty at ichips.intel.com> wrote:
> > 
> > > This patch begins to add in functionality needed by the SMI implementation.
> > 
> > Let's try this again.  Moved SMI specific code from ib_mad.h to 
> > ib_smi.h.  Updated printk from previous patch.  
> 
> Looks good. Just one nit:
> In ib_smi.c, don't need to include ib_smi.h as this is included by 
> ib_mad_priv.h.
> 
> > And replaced the Makefile.  (Feel free to ignore the Makefile changes or to replace it with yours.  The current one didn't seem out of date.)
> I would prefer to hold off on the Makefile for now. I have a similar one
> for the tree but we are not quite there yet and I like to prebuild out
> of the tree right now.
> 
> Should I apply the changes (except the Makefile) or do you want to ?

One more thing on the Makefile I forgot to mention (I hit send too
quickly :-(

As ib_verbs.c is in Roland's core right now, if that is the one we
should use, it doesn't need to be part of this build.

-- Hal