[openib-general] [RFC] ib_mad

[Sean Hefty]

On Thu, 16 Sep 2004 15:29:45 -0400
Hal Rosenstock <halr at voltaire.com> wrote:

> Now that I think ib_mad is far enough along, I would like to request any
> code comments. 

I'll start submitting comments in the form of patches.  I'll try to keep each patch as small and contained as possible.  This first one is fairly easy.  I didn't see where struct ib_mad_buf was used.  If it's needed, can it be merged directly into ib_mad_private_header?

My next few patches will be more useful...

- Sean

Index: access/ib_mad_priv.h
===================================================================
--- access/ib_mad_priv.h	(revision 877)
+++ access/ib_mad_priv.h	(working copy)
@@ -76,16 +76,9 @@
 #define MAX_MGMT_CLASS		80	
 #define MAX_MGMT_VERSION	8
 
-
-struct ib_mad_buf {
-	void *mad_buf;
-	DECLARE_PCI_UNMAP_ADDR(mapping)
-};
-
 struct ib_mad_private_header {
 	struct ib_mad_recv_wc recv_wc; /* must be first member (for now !!!) */
 	struct ib_mad_recv_buf recv_buf;
-	struct ib_mad_buf buf;
 } __attribute__ ((packed));
 
 struct ib_mad_private {