[openib-general] Re: [PATCH] mthca: Don't call CQ completion handler if it doesn't exist

Hal Rosenstock halr at voltaire.com
Mon Apr 11 11:57:47 PDT 2005


On Mon, 2005-04-11 at 13:58, Roland Dreier wrote: 
>     Hal> mthca: Don't call CQ completion handler if it doesn't exist
> 
> Why do we want to add this test?  This is adding a conditional branch
> in what I think is a fast path, and I would consider it a bug in the
> consumer if it creates a CQ with an invalid completion handler and
> then requests a completion event for that CQ.  Am I missing something?

Then shouldn't this be indicated as an error at create_cq time ?

-- Hal




More information about the general mailing list