[openib-general] [PATCH][RFC][1/4] IB: core changes for userspace verbs

Roland Dreier roland at topspin.com
Wed Apr 20 09:48:05 PDT 2005


    Krishna> 1. In ib_umem_get(), I see you set ret = 0, which is
    Krishna> unnecessary because chunk-> nents is set based on ret
    Krishna> value. Plus you already have a "while (ret)" to break
    Krishna> out. "ret = 0" can be safely removed.

Actually, I know why "ret = 0" is there: although it's not strictly
needed, gcc isn't smart enough to see that, and without the
initialization, it warns that "'ret' might be used uninitialized in
this function."

 - R.




More information about the general mailing list