[openib-general] kdapl build error on ia64

[John Partridge]

Yes, that's right, but, I need to test it on ia32 too to make sure it
not break anything there .

John


Talpey, Thomas wrote:
> It doesn't need two printk's, the one printk just needs
> to have %lu as its format (instead of %ld), right?
> 
> Tom.
> 
> 
> At 12:21 PM 8/1/2005, John Partridge wrote:
> 
>>Hal,
>>
>>No the patch did not fix the warnings :-
>>
>>	  CC [M]  drivers/infiniband/ulp/kdapl/ib/dapl_openib_qp.o
>>	  CC [M]  drivers/infiniband/ulp/kdapl/ib/dapl_openib_util.o
>>	  CC [M]  drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.o
>>	drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c: In function 
>>`dapl_path_comp_handler':
>>	drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c:346: warning: long 
>>long int format, u64 arg (arg 3)
>>	drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c: In function 
>>`dapl_rt_comp_handler':
>>	drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c:416: warning: long 
>>long int format, u64 arg (arg 3)
>>
>>Let me look at it and I will produce a patch that fixes the build 
>>error and the warnings OK ?
>>
>>Cheers
>>John
>>
>>
>>Hal Rosenstock wrote:
>>
>>>Hi John,
>>>
>>>My normal email sending is not working right now so I am using an 
>>
>>alternate method.
>>
>>>Hope the formatting comes through OK.
>>>
>>>On Fri, 2005-07-29 at 17:46, John Partridge wrote:
>>>
>>>
>>>>With this fix the ia64 modules all build to completion with just a 
>>>>couple of warnings :-
>>>
>>>
>>>>  CC [M]  drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.o
>>>>drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c: In function 
>>
>>`dapl_path_comp_handler':
>>
>>>>drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c:346: warning: long 
>>
>>long int format, u64 arg (arg 3)
>>
>>>>drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c: In function 
>>
>>`dapl_rt_comp_handler':
>>
>>>>drivers/infiniband/ulp/kdapl/ib/dapl_openib_cm.c:416: warning: long 
>>
>>long int format, u64 arg (arg 3)
>>
>>>
>>>Can you try this patch and see if it removes the warnings ?
>>>
>>>Thanks.
>>>
>>>-- Hal
>>>
>>>Index: dapl_openib_cm.c
>>>===================================================================
>>>--- dapl_openib_cm.c    (revision 2935)
>>>+++ dapl_openib_cm.c    (working copy)
>>>@@ -341,9 +341,15 @@ static void dapl_path_comp_handler(u64 r
>>>                                              &cm_ctx->dapl_path, 1,
>>>                                              &cm_ctx->dapl_comp);
>>>                if (status) {
>>>+#if defined(__ia64__)
>>>+                       printk(KERN_ERR "dapl_path_comp_handler: "
>>>+                              "ib_at_paths_by_route returned %d id %ld\n",
>>>+                              status, cm_ctx->dapl_comp.req_id);
>>>+#else
>>>                        printk(KERN_ERR "dapl_path_comp_handler: "
>>>                               "ib_at_paths_by_route returned %d id %lld\n",
>>>                               status, cm_ctx->dapl_comp.req_id);
>>>+#endif
>>>                        event = DAT_CONNECTION_EVENT_BROKEN;
>>>                        goto error;
>>>                }
>>>@@ -412,8 +418,13 @@ static void dapl_rt_comp_handler(u64 req
>>>        status = ib_at_paths_by_route(&cm_ctx->dapl_rt, 0, 
>>
>>&cm_ctx->dapl_path, 1,
>>
>>>                                      &cm_ctx->dapl_comp);
>>>        if (status) {
>>>+#if defined(__ia64__)
>>>+               printk(KERN_ERR "dapl_rt_comp_handler: ib_at_paths_by_route "
>>>+                      "returned %d id %ld\n", status, 
>>
>>cm_ctx->dapl_comp.req_id);
>>
>>>+#else
>>>                printk(KERN_ERR "dapl_rt_comp_handler: ib_at_paths_by_route "
>>>                       "returned %d id %lld\n", status, 
>>
>>cm_ctx->dapl_comp.req_id);
>>
>>>+#endif
>>>                event = DAT_CONNECTION_EVENT_BROKEN;
>>>                goto error;
>>>        }
>>
>>-- 
>>John Partridge
>>
>>Silicon Graphics Inc
>>Tel:  651-683-3428
>>Vnet: 233-3428
>>E-Mail: johnip at sgi.com
>>_______________________________________________
>>openib-general mailing list
>>openib-general at openib.org
>>http://openib.org/mailman/listinfo/openib-general
>>
>>To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>>
>>

-- 
John Partridge

Silicon Graphics Inc
Tel:  651-683-3428
Vnet: 233-3428
E-Mail: johnip at sgi.com