[openib-general] Re: [PATCH] remove in_atomic

Libor Michalek limichal at cisco.com
Thu Aug 4 16:49:24 PDT 2005


On Mon, Aug 01, 2005 at 09:35:29AM +0300, Michael S. Tsirkin wrote:
> in_atomic isnt a reliable way to check that we are in an atomic context.
> Just schedule work, always, since most cq polling is currently done under
> a spinlock, anyway.

  I agree this patch is correct, but did you see any performance change?
With it applied I'm seeing a lot more variance in performance from run
to run. I believe the differences look to do with timing and how
frequently we are using source rdma advertisement vs. the sink. I believe
the slow start algorithm for src_avails needs improvment.

-Libor



More information about the general mailing list