[openib-general] RE: [PATCH] amso1100: use standard byteorder macros

Christoph Hellwig hch at lst.de
Fri Aug 12 00:12:23 PDT 2005


On Thu, Aug 11, 2005 at 04:13:24PM -0700, Roland Dreier wrote:
>     Tom> Christoph: This is great stuff, but would be even better if
>     Tom> we just globally replaced thinks like "cpu_to_wr64" with
>     Tom> "cpu_to_be64" and removed the cc_byteorder.h file altogether?
> 
> Yes, if your byte order is definitely frozen to big-endian, then you
> should definitely killall the cpu_to_wrXX wrappers.

Agreed.  This was just the most trivial obvious correct patch to get
things to mostly compile on ppc.

I'll do a new round of patches when I find time.



More information about the general mailing list