[openib-general] Re: [PATCH] sockaddr_ll change for IPoIB interface

[Talpey, Thomas]

At 11:52 PM 8/11/2005, Tom Duffy wrote:
>
>On Aug 11, 2005, at 2:38 PM, Hal Rosenstock wrote:
>> Can anyone think of another approach to do this and keep backward
>> compatibility ?
>
>Do we need backward compatibility?  How about the stuff that includes  
>if_packet.h gets rebuilt?  You are adding to the end of the struct,  
>after all.

The size of the struct is less of an issue than the test for
ARPHRD_INFINIBAND. David said as much:

-- it won't work for anything else without adding
-- more special tests to that af_packet.c code

I have to say, SOCKADDR_COMPAT_LL is pretty stinky too.

Hal, why *are* you testing for ARPHRD_INFINIBAND anyway?
What different action happens in the transport-independent
code in this special case?

Tom.