[openib-general] Re: [PATCH] sockaddr_ll change for IPoIB interface

Hal Rosenstock halr at voltaire.com
Fri Aug 12 07:12:41 PDT 2005


On Fri, 2005-08-12 at 09:52, Talpey, Thomas wrote:
> At 09:01 AM 8/12/2005, Hal Rosenstock wrote:
> >It is done to preserve length checks that were already there (on struct
> >msghdr in packet_sendmsg and addr_len in packet_bind). I didn't want to
> >weaken that.
> 
> Are you sure things break if you simply build a message in user space
> that's got the larger address (without changing the sockaddr_ll at all)?
> It looks to me as if msg->msg_namelen/msg_name can be any appropriate
> size which is at least as large as the sockaddr_ll.

I think that's where I started on this. I didn't change sockaddr_ll and
it didn't work for IPoIB link level messages but at this point, I'm no
longer 100% sure so I will check again (it may have been due to some
other problem).

If sockaddr_ll struct is left alone, I think it may be a problem on the
receive side where the size of that struct is used.

-- Hal




More information about the general mailing list