[openib-general] RE: [PATCH] osm: add a main auto tools project for osm

[Eitan Zahavi]

Hi Hal,

> A couple of things:
> 
> The patch appears to be whitespace wrapped.
> patching file include/configure.in
> patch: **** malformed patch at line 11: depend on?
[EZ] I used Thunderbird which to my best knowledge does not corrupt the
white space.

> 
> Also for debug, should -O0 be removed as Michael suggests ?
[EZ] I will provide a mode where if the user provide a CLAFS on the command
line that includes other optimization mode it will be used. The problem with
MST proposal is that if one does not provide CFLAGS the default would have
been -O2 .
So I'm looking for a way to use a default of -O0 on debug builds. 

Should I provide the patch in pieces or wait until all these features are
in?
> 
> Also, why are files without changes included in the patch ?
[EZ] I will double check.
> 
> Thanks
> 
> -- Hal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050814/5a896897/attachment.html>