[openib-general] Re: [PATCH] SDP: fix oops with port reuse

[Tom Duffy]

On Aug 16, 2005, at 2:19 AM, Michael S. Tsirkin wrote:

> This is what I committed. I'm not against making sdp_inet_port_put  
> void,
> looking at libsdp this shouldnt introduce any problems, but lets  
> make it
> a separate patch.

I agree that changing it to void should be done separately.  But, I  
thought that we didn't want to remove the port unless it was really  
on the list and that just checking if the src_port was set wouldn't  
guarantee this.

> Maybe its a good idea to init bind_next at socket creation, at  
> port_put
> we could call list_del_init, and/or use list_empty to figure out
> whether the socket is on the bind list.

Do you mean we would setup the bind_next field to point to itself?   
This is normally reserved for list heads.

-tduffy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20050816/b2be79d6/attachment.html>