[openib-general] [PATCH][iWARP] Added provider CM verbs andquery provider methods

[Steve Wise]

> -----Original Message-----
> From: openib-general-bounces at openib.org 
> [mailto:openib-general-bounces at openib.org] On Behalf Of Roland Dreier
> Sent: Thursday, August 25, 2005 11:06 AM
> To: Tom Tucker
> Cc: openib-general at openib.org
> Subject: Re: [openib-general] [PATCH][iWARP] Added provider 
> CM verbs andquery provider methods
> 
>     Tom> This patch is against the iWARP branch. It adds CM related
>     Tom> methods to the ib_device structure as well as simple versions
>     Tom> of the low level port, gid, pkey, etc... query methods.
> 
> This patch doesn't seem like the right approach to me.  I don't think
> we want to put CM methods, which are not very verb-like, in to the
> device structure.  For one thing, connect_qp() seems like it can just
> be replaced by the existing modify_qp() method.
> 
> I'm not sure I understand the rest of the methods.  It seems that the
> Ammasso device doesn't really implement the RNIC verbs.  I'm guessing
> you handle all the connection stuff inside your device, which means
> that you can't implement the standard iWARP modify-to-RTS operation.
>

Since there was no way to do migration of a linux native stack
connection to the rnic, we chose to model the product after the _only_
API available...DAPL.  The RDMAC verbs punts entirely on connection
setup -and- is modeled to support a chimney approach which will never be
in linux as far as I can tell.

Would you rather we put this in a CM device struct of some sort?  And
have rnic devices export a CM device that has these sorts of methods?
To me that's basically the same as adding it to the struct ib_device.  

> Is there a way to make your interface look more like the iWARP verbs
> interface?  Or do all iWARP devices have an interface like yours.
> 

Well, i haven't seen any other iwarp device at this detail (i only know
of three iwarp devices in existance), so i cannot tell you.  Perhaps the
other vendors can respond.

Stevo.