[openib-general] [PATCH] IBAT resolve_ats_route

James Lentini jlentini at netapp.com
Fri Aug 26 13:42:44 PDT 2005


Hi Hal,

I was reading through the IBAT sources when I noticed that in 
resolve_ats_route() you set req->pend.sa_query to null on line 1127 
and then check to see if it is null a few lines later. I don't think 
you need to do that.

Signed-off-by: James Lentini <jlentini at netapp.com>

Index: at.c
===================================================================
--- at.c	(revision 3204)
+++ at.c	(working copy)
@@ -1134,10 +1134,6 @@ static int resolve_ats_route(struct rout
 	}
 
 	if (!rec) {	/* new query */
-		if (req->pend.sa_query) {
-			DEBUG("req %p (%s) already pending", req, netdev->name);
-			return -1;
-		}
 		build_ats_req(&sa_rec, NULL, req->src.pkey, req->dst_ip);
 		rec = &sa_rec;
 	}



More information about the general mailing list