[openib-general] Re: [PATCH] RMPP: Fix length in first segment of multipacket sends

Michael S. Tsirkin mst at mellanox.co.il
Mon Aug 29 00:23:16 PDT 2005


Quoting Hal Rosenstock <halr at voltaire.com>:
> Index: mad_rmpp.c
> ===================================================================
> --- mad_rmpp.c  (revision 3197)
> +++ mad_rmpp.c  (working copy)
> @@ -593,7 +593,8 @@

Hal, could you diff with -p in the future please?
This makes the function name visible in the patch, making it
possible to understand what is being changed without applying it.

>                 rmpp_mad->rmpp_hdr.paylen_newwin =
>                         cpu_to_be32(mad_send_wr->total_seg *
>                                     (sizeof(struct ib_rmpp_mad) -
> -                                      offsetof(struct ib_rmpp_mad, data)));
> +                                      offsetof(struct ib_rmpp_mad, data)) -
> +                                   mad_send_wr->pad);

BTW, I just noticed that whitespace was (and remains) broken in these lines:
indentation is done by spaces.

Thanks,
-- 
MST



More information about the general mailing list