[openib-general] Re: mthca_multicast_attach/detach questions

[Roland Dreier]

    Michael> Hello, Roland!  1. error handling in
    Michael> mthca_multicast_attach looks strange: in particular, dont
    Michael> we want to revert the result of mthca_alloc if QP is
    Michael> already a member of MGM, or if MGM is full?

Yes, I would use the word "wrong" instead of "strange."  We certainly
have to undo the alloc if something after it fails.

    Michael> 2. mthca_multicast_detach has an unconditional goto

    Michael>         if (i != 1) goto out;

    Michael>         goto out;

    Michael> this looks wrong: it seems you'll never remove an empty
    Michael> multicast group.

Yes, the second goto looks wrong as well... probably some sort of
typing/editing error in the past.

 - R.