[openib-general] [PATCH applied] sdp: fix kunmap_atomic usage

Michael S. Tsirkin mst at mellanox.co.il
Sat Dec 10 13:21:40 PST 2005


SDP was using kunmap_atomic incorrectly.
Of course, I'm typically using it on platforms where its a nop,
so I dint notice :)

The following is already applied.

---

kunmap_atomic gets a virtual address, not a page* pointer.

Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>

Index: openib/drivers/infiniband/ulp/sdp/sdp_send.c
===================================================================
--- openib/drivers/infiniband/ulp/sdp/sdp_send.c	(revision 4369)
+++ openib/drivers/infiniband/ulp/sdp/sdp_send.c	(working copy)
@@ -647,7 +647,7 @@ static int sdp_send_data_iocb_src(struct
 
 		memcpy(buff->tail, addr + off, len);
 
-		kunmap_atomic(iocb->page_array[pos], KM_IRQ0);
+		kunmap_atomic(addr, KM_IRQ0);
 
 		local_irq_restore(flags);
 
Index: openib/drivers/infiniband/ulp/sdp/sdp_recv.c
===================================================================
--- openib/drivers/infiniband/ulp/sdp/sdp_recv.c	(revision 4369)
+++ openib/drivers/infiniband/ulp/sdp/sdp_recv.c	(working copy)
@@ -618,7 +618,7 @@ static int sdp_read_buff_iocb(struct sdp
 
 		iocb->io_addr += copy;
 
-		kunmap_atomic(iocb->page_array[counter], KM_IRQ0);
+		kunmap_atomic(addr, KM_IRQ0);
 		++counter;
 
 		local_irq_restore(flags);

-- 
MST



More information about the general mailing list