[openib-general] Re: [PATCH 04/13] [RFC] ipath LLD core, part 1

[Robert Walsh]

On Sat, 2005-12-17 at 12:38 -0800, Andrew Morton wrote:
> Roland Dreier <rolandd at cisco.com> wrote:
> >
> > +	if ((ret = copy_from_user(&rpkt, p, sizeof rpkt))) {
> > +		_IPATH_DBG("Failed to copy in pkt struct (%d)\n", ret);
> > +		return ret;
> > +	}
> 
> The driver does this quite a lot.  copy_from_user() will return the number
> of bytes remaining to copy.  So I think we'll be wanting `return -EFAULT;'
> in lots of places rather than this.

Thanks.  Will fix.

Regards,
 Robert.

-- 
Robert Walsh                                 Email: rjwalsh at pathscale.com
PathScale, Inc.                              Phone: +1 650 934 8117
2071 Stierlin Court, Suite 200                 Fax: +1 650 428 1969
Mountain View, CA 94043.