[openib-general] Re: [PATCH 07/13] [RFC] ipath core misc files

[Robert Walsh]

On Sat, 2005-12-17 at 19:10 -0800, Andrew Morton wrote:
> Robert Walsh <rjwalsh at pathscale.com> wrote:
> >
> > > > +int ipath_mlock(unsigned long start_page, size_t num_pages, struct page **p)
> > > OK.  It's perhaps not a very well named function.
> > 
> > Really?  Suggestion for a better name?
> > 
> 
> ipath_get_user_pages() would cause the least surprise.

Seems reasonable.  I'll look at the related functions, too.

> > > I don't think we want to be setting the user's VMA's vm_flags in this
> > > manner.  This is purely to retain the physical page across fork?
> > 
> > I didn't write this bit of the driver, but I believe this is the case.
> > Is there a better way of doing this?
> 
> This stuff has been churning a bit lately.  I've drawn Hugh Dickins's
> attention to the patch - he'd have a better handle on what the best
> approach would be.

OK then - I'll wait and see.

Regards,
 Robert.

-- 
Robert Walsh                                 Email: rjwalsh at pathscale.com
PathScale, Inc.                              Phone: +1 650 934 8117
2071 Stierlin Court, Suite 200                 Fax: +1 650 428 1969
Mountain View, CA 94043.