Robert Walsh <rjwalsh at pathscale.com> wrote: > > > I'd be inclined to stick BITS_PER_BYTE into include/linux/types.h. > > Really? I was just going to suggest removing it, but if sticking it in > types.h works for you, then fine. > I think it's a readbility thing. x += 8; /* wtf? */ vs x += BITS_PER_BYTE; /* ah! */