[openib-general] Re: checkstack warnings

[Roland Dreier]

    Michael> Hi!  Running make checkstack on the openib tree generates
    Michael> quite a long list of stack hogs (below).  Do we want to
    Michael> clean the code with respect to these warnings?

It wouldn't hurt to try and improve things, but I don't see anything
really scary here...

 > 0x000007e0 mthca_init_one:                              1048

This one seems pretty bad -- I guess it's -funit-at-a-time going
beserk.  Are you building for x86_64?  What compiler version?

With

    $ gcc --version
    gcc (GCC) 4.0.2 (Debian 4.0.2-2)

I get something slightly different:

   0x000005a0 mthca_init_hca:                              568

is the top offender, and

   0x0000e9a0 mthca_process_mad:                           168

is the second-biggest function.

In any case it might be worth dynamically allocating some of the large
structures used in the init path, just to be safe.

 - R.