[openib-general] Re: [PATCH] InfiniBand: add missing break between cases

Michael S. Tsirkin mst at mellanox.co.il
Wed Feb 2 21:50:43 PST 2005


BTW, is the lack of break after
case MTHCA_RES_UDAV intentional in mthca_make_profile?
Isnt this what was intended ( I noticed this when comparing trunk with
roland-uverbs)?

Signed-off-by: Michael S. Tsirkin <mst at mellanox.co.il>

Index: hw/mthca/mthca_profile.c
===================================================================
--- hw/mthca/mthca_profile.c	(revision 1673)
+++ hw/mthca/mthca_profile.c	(working copy)
@@ -241,6 +241,7 @@ u64 mthca_make_profile(struct mthca_dev 
 		case MTHCA_RES_UDAV:
 			dev->av_table.ddr_av_base = profile[i].start;
 			dev->av_table.num_ddr_avs = profile[i].num;
+			break;
 		case MTHCA_RES_UARC:
 			init_hca->uarc_base   = profile[i].start;
 			init_hca->log_uarc_sz = ffs(request->uarc_size) - 13;

-- 
MST - Michael S. Tsirkin



More information about the general mailing list